Stream: git-wasmtime

Topic: wasmtime / PR #3366 Move `custom_limiter_detect_os_oom_fa...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 19:30):

alexcrichton opened PR #3366 from fix-flaky-test to main:

This test uses rlimit which can't be executed in parallel with other
tests. Previously this used libc::fork but the call afterwards to
libc::wait was racing all other child subprocesses since it would wait
for any child instead of the specific child we were interested in. There
was also difficulty getting the output of the child on failure coming
to the parent, so this commit simplifies the situation by moving the
test to its own executable where it's the only test.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 20:15):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 20:47):

alexcrichton merged PR #3366.


Last updated: Dec 23 2024 at 12:05 UTC