Stream: git-wasmtime

Topic: wasmtime / PR #3366 Move `custom_limiter_detect_os_oom_fa...

Wasmtime GitHub notifications bot (Sep 17 2021 at 19:30):

alexcrichton opened PR #3366 from fix-flaky-test to main:

This test uses rlimit which can't be executed in parallel with other
tests. Previously this used libc::fork but the call afterwards to
libc::wait was racing all other child subprocesses since it would wait
for any child instead of the specific child we were interested in. There
was also difficulty getting the output of the child on failure coming
to the parent, so this commit simplifies the situation by moving the
test to its own executable where it's the only test.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 17 2021 at 20:15):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2021 at 20:47):

alexcrichton merged PR #3366.

Last updated: Oct 23 2024 at 20:03 UTC