Stream: git-wasmtime

Topic: wasmtime / PR #3362 Implement `Unarrow`, `Uunarrow`, and ...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 12:27):

dheaton-arm opened PR #3362 from implement-unarrow to main:

Implemented the following Opcodes for the Cranelift interpreter:

Note that all 3 instructions saturate at the type boundaries.

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin created PR review comment:

Could you turn this into an iterator chain?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin created PR review comment:

The u128::MAX as i128 will overflow, which I guess is fine because I think this is just using the i128 as a container for the 128 bits, immediately passed into a Value::int call. But given that, could you use u128 instead? IMHO the unsigned types are a bit more idiomatic for "just a bit pattern"-type values.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2021 at 08:28):

dheaton-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2021 at 08:28):

dheaton-arm created PR review comment:

Sure; I'd gone for i128 because Value::int accepts i128 rather than u128.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2021 at 13:11):

dheaton-arm updated PR #3362 from implement-unarrow to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2021 at 08:24):

dheaton-arm requested cfallin for a review on PR #3362.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin created PR review comment:

Ah, OK, possibly that could be changed too, but it's not terribly important in this case so I won't hold up the PR for this :-)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin merged PR #3362.


Last updated: Dec 23 2024 at 12:05 UTC