Stream: git-wasmtime

Topic: wasmtime / PR #3362 Implement `Unarrow`, `Uunarrow`, and ...

Wasmtime GitHub notifications bot (Sep 17 2021 at 12:27):

dheaton-arm opened PR #3362 from implement-unarrow to main:

Implemented the following Opcodes for the Cranelift interpreter:

• Unarrow to combine two SIMD vectors into a new vector with twice
  the lanes but half the width, with signed inputs which are clamped to
  0x00.

• Uunarrow to perform the same operation as Unarrow but treating
  inputs as unsigned.

• Snarrow to perform the same operation as Unarrow but treating
  both inputs and outputs as signed, and saturating accordingly.

Note that all 3 instructions saturate at the type boundaries.

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin created PR review comment:

Could you turn this into an iterator chain?

Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin created PR review comment:

The u128::MAX as i128 will overflow, which I guess is fine because I think this is just using the i128 as a container for the 128 bits, immediately passed into a Value::int call. But given that, could you use u128 instead? IMHO the unsigned types are a bit more idiomatic for "just a bit pattern"-type values.

Wasmtime GitHub notifications bot (Sep 17 2021 at 19:54):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 20 2021 at 08:28):

dheaton-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 20 2021 at 08:28):

dheaton-arm created PR review comment:

Sure; I'd gone for i128 because Value::int accepts i128 rather than u128.

Wasmtime GitHub notifications bot (Sep 20 2021 at 13:11):

dheaton-arm updated PR #3362 from implement-unarrow to main.

Wasmtime GitHub notifications bot (Sep 21 2021 at 08:24):

dheaton-arm requested cfallin for a review on PR #3362.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin created PR review comment:

Ah, OK, possibly that could be changed too, but it's not terribly important in this case so I won't hold up the PR for this :-)

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:06):

cfallin merged PR #3362.

Last updated: Nov 22 2024 at 17:03 UTC