sunfishcode opened PR #3360 from sunfishcode/builtin-setjmp
to main
:
Use [
__builtin_setjmp
] instead ofsigsetjmp
, as it is implemented in
the compiler, performed inline, and saves much less state. This speeds up
calls into wasm by about 8% on my machine.[
__builtin_setjmp
]: https://gcc.gnu.org/onlinedocs/gcc/Nonlocal-Gotos.html<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
sunfishcode requested alexcrichton for a review on PR #3360.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
Is this the right size on all architectures?
bjorn3 edited PR review comment.
sunfishcode submitted PR review.
sunfishcode created PR review comment:
sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp
to main
.
sunfishcode submitted PR review.
sunfishcode created PR review comment:
I've now added a comment about this.
alexcrichton submitted PR review.
sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp
to main
.
sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp
to main
.
sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp
to main
.
alexcrichton merged PR #3360.
Last updated: Dec 23 2024 at 12:05 UTC