Stream: git-wasmtime

Topic: wasmtime / PR #3360 Use `__builtin_setjmp` instead of `si...

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:47):

sunfishcode opened PR #3360 from sunfishcode/builtin-setjmp to main:

Use [__builtin_setjmp] instead of sigsetjmp, as it is implemented in
the compiler, performed inline, and saves much less state. This speeds up
calls into wasm by about 8% on my machine.

[__builtin_setjmp]: https://gcc.gnu.org/onlinedocs/gcc/Nonlocal-Gotos.html

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:47):

sunfishcode requested alexcrichton for a review on PR #3360.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:49):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:49):

bjorn3 created PR review comment:

Is this the right size on all architectures?

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:50):

bjorn3 edited PR review comment.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:50):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:50):

sunfishcode created PR review comment:

Yes

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:52):

sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp to main.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:52):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Sep 16 2021 at 17:52):

sunfishcode created PR review comment:

I've now added a comment about this.

Wasmtime GitHub notifications bot (Sep 16 2021 at 18:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 16 2021 at 18:54):

sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp to main.

Wasmtime GitHub notifications bot (Sep 16 2021 at 21:11):

sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp to main.

Wasmtime GitHub notifications bot (Sep 16 2021 at 21:37):

sunfishcode updated PR #3360 from sunfishcode/builtin-setjmp to main.

Wasmtime GitHub notifications bot (Sep 20 2021 at 14:14):

alexcrichton merged PR #3360.

Last updated: Nov 22 2024 at 17:03 UTC