Stream: git-wasmtime

Topic: wasmtime / PR #3346 Modify the `poll_oneoff_files` test t...

Wasmtime GitHub notifications bot (Sep 13 2021 at 18:42):

sunfishcode opened PR #3346 from sunfishcode/poll-oneoff-retry to main:

Modify the poll_oneoff_files test to avoid assuming that poll_oneoff
returns all pending events, as it may sometimes return only a subset of
events. When multiple events are expected, use a loop, and loop until
all events have been recorded.

This hopefully helps with https://github.com/bytecodealliance/wasmtime/issues/3339.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 13 2021 at 19:59):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2021 at 19:59):

alexcrichton merged PR #3346.

Last updated: Nov 22 2024 at 17:03 UTC