Stream: git-wasmtime

Topic: wasmtime / PR #3344 Load generated trampolines into jitdu...

Wasmtime GitHub notifications bot (Sep 13 2021 at 16:06):

alexcrichton opened PR #3344 from jitdump-trampoline to main:

This commit updates the jitdump profiler to generate JIT profiling
records for generated trampolines in a wasm module in addition to the
functions already in a module. It's also updated to learn about
trampolines generated via Func::new and friends. These trampolines
were all not previously registered meaning that stack traces with these
pc values would be confusing to see in the profile output. While the
names aren't the best it should at least be more clear than before if a
function is hot!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 13 2021 at 17:35):

alexcrichton updated PR #3344 from jitdump-trampoline to main.

Wasmtime GitHub notifications bot (Sep 21 2021 at 14:53):

alexcrichton requested fitzgen for a review on PR #3344.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:04):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:04):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:04):

fitzgen created PR review comment:

Heads up @jlb6740, since you're the original author of the VTune support: generated trampolines for calling into Wasm weren't previously being registered for profilers (see the top-level PR description) and there are some updates needed for including them in the VTune support. See the jitdump support in this PR for an idea of the kind of thing needed. I don't know exactly what is needed for VTune.

Wasmtime GitHub notifications bot (Sep 21 2021 at 18:05):

alexcrichton merged PR #3344.

Last updated: Nov 22 2024 at 16:03 UTC