Stream: git-wasmtime

Topic: wasmtime / PR #3341 cranelift: Fix invalid trampoline whe...

Wasmtime GitHub notifications bot (Sep 13 2021 at 13:39):

afonso360 opened PR #3341 from trampoline-bool-vecs to main:

Hey,

This is a extension of #3306. In that PR we accidentally only dealt with receiving bool vectors as arguments to the callee function. This caused issues in #3332 where those tests were failing to run on the real backends, due to the generated trampoline being invalid for bool vectors.

For more context about this, see this comment with the invalid trampoline, and the rest of the thread with a proposed solution.

The solution here is not great, bint with the correct type would fix this, but is not implemented in some backends, same with bmask. raw_bitcast solves the issue, but we really should fix bmask/bint and use that.

Fixing trampoline bool args is tracked in #2237

Fixes #3334
Fixes #3335

Wasmtime GitHub notifications bot (Sep 13 2021 at 14:33):

afonso360 edited PR #3341 from trampoline-bool-vecs to main:

Hey,

This is a extension of #3306. In that PR we accidentally only dealt with receiving bool vectors as arguments to the callee function. This caused issues in #3332 where those tests were failing to run on the real backends, due to the generated trampoline being invalid when the callee returns bool vectors.

For more context about this, see this comment with the invalid trampoline, and the rest of the thread with a proposed solution.

The solution here is not great, bint with the correct type would fix this, but is not implemented in some backends, same with bmask. raw_bitcast solves the issue, but we really should fix bmask/bint and use that.

Fixing trampoline bool args is tracked in #2237

Fixes #3334
Fixes #3335

Wasmtime GitHub notifications bot (Sep 21 2021 at 17:46):

afonso360 closed without merge PR #3341.

Last updated: Nov 22 2024 at 17:03 UTC