Wasmtime GitHub notifications bot (Sep 11 2021 at 13:08): Wasmtime GitHub notifications bot (Sep 11 2021 at 13:08):uweigand opened PR #3329 from datavalue-endian-fix to main:
PR https://github.com/bytecodealliance/wasmtime/pull/3187 introduced a
change to the write_to_slice and read_from_slice routines in
data_value.rs that switched byte order on big-endian systems:
the code used to use native byte order, and now hard-codes
little-endian byte order.Fix by using native byte order again.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 17 2021 at 21:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 17 2021 at 21:55):cfallin merged PR #3329.
Last updated: Dec 23 2024 at 12:05 UTC