Stream: git-wasmtime

Topic: wasmtime / PR #3323 Unwind info cleanups

Wasmtime GitHub notifications bot (Sep 09 2021 at 19:48):

fitzgen opened PR #3323 from unwind-info-cleanups to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 09 2021 at 19:48):

fitzgen requested alexcrichton for a review on PR #3323.

Wasmtime GitHub notifications bot (Sep 09 2021 at 19:49):

fitzgen closed without merge PR #3323.

Wasmtime GitHub notifications bot (Sep 09 2021 at 19:50):

fitzgen reopened PR #3323 from unwind-info-cleanups to main.

Wasmtime GitHub notifications bot (Sep 09 2021 at 19:50):

fitzgen updated PR #3323 from unwind-info-cleanups to main.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:36):

alexcrichton created PR review comment:

I think this branch needs a rebase on main, but as a heads up when you do that self.isa is now also stored within the ObjectBuilder itself so it'll no longer need to be an argument here.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:36):

alexcrichton created PR review comment:

FWIW I don't think it's worth doing the debug_assertions dance here, I'd just make everything assert! to unconditionally check.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:36):

alexcrichton created PR review comment:

I think that this 0x1000 can probably be region::page::size() here in this crate

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:37):

fitzgen updated PR #3323 from unwind-info-cleanups to main.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:39):

fitzgen updated PR #3323 from unwind-info-cleanups to main.

Wasmtime GitHub notifications bot (Sep 09 2021 at 20:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2021 at 21:38):

fitzgen merged PR #3323.

Last updated: Nov 22 2024 at 16:03 UTC