fitzgen opened PR #3323 from unwind-info-cleanups
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen requested alexcrichton for a review on PR #3323.
fitzgen closed without merge PR #3323.
fitzgen reopened PR #3323 from unwind-info-cleanups
to main
.
fitzgen updated PR #3323 from unwind-info-cleanups
to main
.
alexcrichton submitted PR review.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
I think this branch needs a rebase on
main
, but as a heads up when you do thatself.isa
is now also stored within theObjectBuilder
itself so it'll no longer need to be an argument here.
alexcrichton created PR review comment:
FWIW I don't think it's worth doing the
debug_assertions
dance here, I'd just make everythingassert!
to unconditionally check.
alexcrichton created PR review comment:
I think that this
0x1000
can probably beregion::page::size()
here in this crate
fitzgen updated PR #3323 from unwind-info-cleanups
to main
.
fitzgen updated PR #3323 from unwind-info-cleanups
to main
.
alexcrichton submitted PR review.
fitzgen merged PR #3323.
Last updated: Dec 23 2024 at 12:05 UTC