Wasmtime GitHub notifications bot (Sep 06 2021 at 19:30): Wasmtime GitHub notifications bot (Sep 06 2021 at 19:30):afonso360 opened PR #3306 from trampoline-simd-bools to main:
This PR adds support for SIMD bools in the trampoline.
Its based on #3304, we probably should wait until that one is merged before reviewing this. So that changes don't appear here as well.
Fixing trampoline bool args is tracked in #2237
Wasmtime GitHub notifications bot (Sep 06 2021 at 19:31):afonso360 edited PR #3306 from trampoline-simd-bools to main:
This PR adds support for SIMD bools in the trampoline.
Its based on #3304, we probably should wait until that one is merged before reviewing this. So that changes don't appear here as well.
Alternatively I can push these changes onto that PR, but i felt that it would be too many changes for a single PR.
Fixing trampoline bool args is tracked in #2237
Wasmtime GitHub notifications bot (Sep 06 2021 at 19:38):afonso360 updated PR #3306 from trampoline-simd-bools to main.
Wasmtime GitHub notifications bot (Sep 07 2021 at 16:54):afonso360 updated PR #3306 from trampoline-simd-bools to main.
Wasmtime GitHub notifications bot (Sep 07 2021 at 16:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2021 at 16:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 07 2021 at 16:55):cfallin created PR review comment:
Can you turn this sequence into a helper on the type itself? Something like
param.value_type.coerce_bools_to_ints()would be reasonable, IMHO...
Wasmtime GitHub notifications bot (Sep 10 2021 at 14:42):afonso360 updated PR #3306 from trampoline-simd-bools to main.
Wasmtime GitHub notifications bot (Sep 10 2021 at 14:46):afonso360 updated PR #3306 from trampoline-simd-bools to main.
Wasmtime GitHub notifications bot (Sep 10 2021 at 19:31):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 10 2021 at 19:31):cfallin merged PR #3306.
Last updated: Nov 22 2024 at 17:03 UTC