alexcrichton opened PR #3301 from rm-wasm2obj
to main
:
This commit removes the
wasm2obj
subcommand of thewasmtime
CLI.
This subcommand has a very long history and dates back quite far. While
it's existed, however, it's never been documented in terms of the output
it's produced. AFAIK it's only ever been used for debugging to see the
machine code output of Wasmtime on some modules. With recent changes to
the module serialization output the output ofwasmtime compile
, the
*.cwasm
file, is now a native ELF file which can be fed to standard
tools likeobjdump
. Consequently I dont think there's any remaining
need to keepwasm2obj
around itself, so this commit removes the
subcommand.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey submitted PR review.
bjorn3 created PR review comment:
Is this function still used anywhere?
bjorn3 submitted PR review.
alexcrichton updated PR #3301 from rm-wasm2obj
to main
.
alexcrichton updated PR #3301 from rm-wasm2obj
to main
.
alexcrichton merged PR #3301.
Last updated: Dec 23 2024 at 12:05 UTC