Stream: git-wasmtime

Topic: wasmtime / PR #3301 Remove the `wasmtime wasm2obj` command

Wasmtime GitHub notifications bot (Sep 03 2021 at 19:01):

alexcrichton opened PR #3301 from rm-wasm2obj to main:

This commit removes the wasm2obj subcommand of the wasmtime CLI.
This subcommand has a very long history and dates back quite far. While
it's existed, however, it's never been documented in terms of the output
it's produced. AFAIK it's only ever been used for debugging to see the
machine code output of Wasmtime on some modules. With recent changes to
the module serialization output the output of wasmtime compile, the
*.cwasm file, is now a native ELF file which can be fed to standard
tools like objdump. Consequently I dont think there's any remaining
need to keep wasm2obj around itself, so this commit removes the
subcommand.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 03 2021 at 19:03):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Sep 03 2021 at 19:27):

bjorn3 created PR review comment:

Is this function still used anywhere?

Wasmtime GitHub notifications bot (Sep 03 2021 at 19:27):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 03 2021 at 20:10):

alexcrichton updated PR #3301 from rm-wasm2obj to main.

Wasmtime GitHub notifications bot (Sep 08 2021 at 15:08):

alexcrichton updated PR #3301 from rm-wasm2obj to main.

Wasmtime GitHub notifications bot (Sep 08 2021 at 15:40):

alexcrichton merged PR #3301.

Last updated: Nov 22 2024 at 16:03 UTC