Stream: git-wasmtime

Topic: wasmtime / PR #3292 Align order of wasm types/values acro...

Wasmtime GitHub notifications bot (Sep 03 2021 at 16:00):

alexcrichton opened PR #3292 from align-val-numbers to main:

Wasmtime has a few representations of Val and ValType across the
internal crates, the wasmtime crate, and the C API. These were
previously sometimes mentioned in different orders which means that
converting between the two took a little extra code than before. This
commit is a micro-optimization to align the types across the various
places we define these to help reduce the codegen burden when converting
between these types.

This is not expected to have a major impact on performance, rather it's
a small cleanup which should be easy-ish to preserve I've noticed while
staring at assembly.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 03 2021 at 16:21):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 03 2021 at 16:21):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Sep 03 2021 at 16:43):

alexcrichton merged PR #3292.

Last updated: Nov 22 2024 at 16:03 UTC