Wasmtime GitHub notifications bot (Sep 02 2021 at 16:18): Wasmtime GitHub notifications bot (Sep 02 2021 at 16:18):dheaton-arm opened PR #3283 from implement-umulhi to main:
Implemented
Umulhifor the Cranelift interpreter, performing unsigned
integer multiplication and producing the high half of a double-length
result.Fixed
ExtractUpperconversion behaviour as part of this change, which
was extracting from a 128-bit value regardless of the size of the
original value.Copyright (c) 2021, Arm Limited.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 02 2021 at 17:03):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 02 2021 at 17:22):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Sep 02 2021 at 17:22):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Sep 02 2021 at 17:22):afonso360 created PR review comment:
Since this isn't testing the SIMD version of these instructions, can we rename this to
umulhi.clif?
Wasmtime GitHub notifications bot (Sep 03 2021 at 10:36):dheaton-arm updated PR #3283 from implement-umulhi to main.
Wasmtime GitHub notifications bot (Sep 03 2021 at 11:05):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Sep 03 2021 at 16:29):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 03 2021 at 16:29):cfallin merged PR #3283.
Last updated: Dec 23 2024 at 12:05 UTC