Stream: git-wasmtime

Topic: wasmtime / PR #3282 cranelift: Fix `br_table` for `i64` t...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 14:43):

afonso360 opened PR #3282 from x64-fix-brtables to main:

With this PR we fix the compilation crash for br_table.i64. We still only support 2^32 targets, but we now allow that number to come from a i64 value.

I don't really know enough about x86 to improve the Inst::JmpTableSeq and enable 2^64 targets, but I suspect its not likely to be an issue.

Fixes #3100. The CLIF Fuzzer found this independently as soon as I added jump tables.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 14:45):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 14:45):

bjorn3 created PR review comment:

You will still have to keep the special case in cranelift/frontend/src/switch.rs for 128bit ints.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 14:57):

afonso360 updated PR #3282 from x64-fix-brtables to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 15:18):

afonso360 updated PR #3282 from x64-fix-brtables to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 15:26):

afonso360 updated PR #3282 from x64-fix-brtables to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 16:58):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 02 2021 at 16:58):

cfallin merged PR #3282.

Last updated: Nov 22 2024 at 16:03 UTC