Stream: git-wasmtime

Topic: wasmtime / PR #3272 Implement `IaddPairwise` for the inte...

Wasmtime GitHub notifications bot (Sep 01 2021 at 12:56):

dheaton-arm opened PR #3272 from implement-iaddpairwise to main:

Implemented IaddPairwise for the Cranelift interpreter, to add pairs
of adjacent values in two SIMD vectors, concatenating them at the end
(preserving both lane size and number of lanes).

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 01 2021 at 13:50):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2021 at 13:50):

afonso360 created PR review comment:

    for pair in arg0.iter().chain(arg1).chunks(2) {
        let lhs: V = Value::int(pair[0], vector_type.lane_type())?;
        let rhs: V = Value::int(pair[1], vector_type.lane_type())?;
        let sum = op(lhs, rhs)?;
        let sum = sum.into_int()?;
        result.push(sum);
    }

Wasmtime GitHub notifications bot (Sep 01 2021 at 13:50):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2021 at 13:52):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2021 at 18:22):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 02 2021 at 13:21):

dheaton-arm updated PR #3272 from implement-iaddpairwise to main.

Wasmtime GitHub notifications bot (Sep 02 2021 at 17:52):

cfallin merged PR #3272.

Last updated: Nov 22 2024 at 16:03 UTC