Wasmtime GitHub notifications bot (Aug 27 2021 at 17:33): Wasmtime GitHub notifications bot (Aug 27 2021 at 17:33):afonso360 opened PR #3258 from ssa-dce to main:
This issue was found by the CLIF fuzzer in #3094.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:34):afonso360 updated PR #3258 from ssa-dce to main.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:36):afonso360 edited PR #3258 from ssa-dce to main:
This issue was found by the CLIF fuzzer in #3094.
It looks like all we need to do is not special case the single predecessor if the predecessor is itself. The normal path includes the operandless param, which is enough to stop the infinite looping.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:37):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:37):bjorn3 created PR review comment:
I think the original comment is still accurate and more descriptive of the problem this prevents.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:37):afonso360 edited PR #3258 from ssa-dce to main:
This issue was found by the CLIF fuzzer in #3094. There is a better description in this comment
It looks like all we need to do is not special case the single predecessor if the predecessor is itself. The normal path includes the operandless param, which is enough to stop the infinite looping.
Wasmtime GitHub notifications bot (Aug 27 2021 at 17:44):afonso360 updated PR #3258 from ssa-dce to main.
Wasmtime GitHub notifications bot (Sep 01 2021 at 10:22):afonso360 updated PR #3258 from ssa-dce to main.
Wasmtime GitHub notifications bot (Sep 01 2021 at 18:19):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 01 2021 at 18:19):cfallin merged PR #3258.
Last updated: Oct 23 2024 at 20:03 UTC