Stream: git-wasmtime

Topic: wasmtime / PR #3247 Merge `wasmtime-jit` and `wasmtime-pr...

Wasmtime GitHub notifications bot (Aug 26 2021 at 03:42):

alexcrichton opened PR #3247 from merge-profiling to main:

This commit merges the wasmtime-profiling crate into the
wasmtime-jit crate. It wasn't really buying a ton being a separate
crate and an upcoming refactoring I'd like to do is to remove the
FinishedFunctions structure. To enable the profilers to work as they
used to this commit changes them to pass CompiledModule as the
argument, but this only works if the profiling trait can see the
CompiledModule type.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 26 2021 at 14:21):

alexcrichton updated PR #3247 from merge-profiling to main.

Wasmtime GitHub notifications bot (Aug 26 2021 at 15:44):

alexcrichton requested cfallin for a review on PR #3247.

Wasmtime GitHub notifications bot (Aug 26 2021 at 15:46):

alexcrichton updated PR #3247 from merge-profiling to main.

Wasmtime GitHub notifications bot (Aug 26 2021 at 16:02):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2021 at 16:18):

alexcrichton requested jlb6740 for a review on PR #3247.

Wasmtime GitHub notifications bot (Aug 26 2021 at 20:21):

jlb6740 submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2021 at 20:21):

jlb6740 created PR review comment:

@alexcrichton Thanks for adding me and looks good. Your initial comment sums up what's going on here. Curious though, why does the dbg_jit_registration need to be refactored to here?

Wasmtime GitHub notifications bot (Aug 26 2021 at 20:22):

jlb6740 submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2021 at 21:00):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2021 at 21:00):

alexcrichton created PR review comment:

I wanted to defer the module_load until the CompiledModule was fully constructed, and then the module_load argument also required the gdbjit image, so I figured I'd just move them together. This doesn't fundamentally change when they happen, it's just deferred slightly in the lifetime of constructing a CompiledModule

Wasmtime GitHub notifications bot (Aug 26 2021 at 21:22):

alexcrichton merged PR #3247.

Last updated: Dec 23 2024 at 12:05 UTC