Stream: git-wasmtime

Topic: wasmtime / PR #3246 Rewrite gdbjit support with safety an...

Wasmtime GitHub notifications bot (Aug 26 2021 at 03:15):

alexcrichton opened PR #3246 from improve-debug to main:

This refactoring primarily removes the dependency of the gdbjit image
creation on the finished_functions array, which shouldn't be necessary
given the input object being passed in since information can be read
from the object instead. Additionally, though, this commit also removes
all unsafe from the file, relying on various tools in the object
crate to parse the internals and update various fields.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 26 2021 at 14:17):

alexcrichton requested cfallin for a review on PR #3246.

Wasmtime GitHub notifications bot (Aug 26 2021 at 15:08):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 26 2021 at 15:44):

alexcrichton merged PR #3246.

Last updated: Dec 23 2024 at 12:05 UTC