Stream: git-wasmtime

Topic: wasmtime / PR #3241 Move trap information to a section of...

Wasmtime GitHub notifications bot (Aug 25 2021 at 15:25):

alexcrichton opened PR #3241 from traps-binary to main:

This commit moves the traps field of FunctionInfo into a section of
the compiled artifact produced by Cranelift. This section is quite large
and when previously encoded/decoded with bincode this can take quite
some time to process. Traps are expected to be relatively rare and it's
not necessarily the right tradeoff to spend so much time
serializing/deserializing this data, so this commit offloads the section
into a custom-encoded binary format located elsewhere in the compiled image.

This is similar to #3240 in its goal which is to move very large pieces
of metadata to their own sections to avoid decoding anything when we
load a precompiled modules. This also has a small benefit that it's
slightly more efficient storage for the trap information too, but that's
a negligible benefit.

This is part of #3230 to make loading modules fast.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 25 2021 at 15:26):

alexcrichton updated PR #3241 from traps-binary to main.

Wasmtime GitHub notifications bot (Aug 26 2021 at 14:17):

alexcrichton requested peterhuene for a review on PR #3241.

Wasmtime GitHub notifications bot (Aug 26 2021 at 21:56):

alexcrichton updated PR #3241 from traps-binary to main.

Wasmtime GitHub notifications bot (Aug 27 2021 at 03:36):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Aug 27 2021 at 03:36):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Aug 27 2021 at 03:36):

peterhuene created PR review comment:

Nit: rename this function and one changed below to lookup_trap_code?

Wasmtime GitHub notifications bot (Aug 27 2021 at 05:42):

alexcrichton updated PR #3241 from traps-binary to main.

Wasmtime GitHub notifications bot (Aug 27 2021 at 06:09):

alexcrichton merged PR #3241.

Last updated: Nov 22 2024 at 17:03 UTC