Wasmtime GitHub notifications bot (Aug 25 2021 at 15:01): Wasmtime GitHub notifications bot (Aug 25 2021 at 15:01):alexcrichton opened PR #3240 from address-map-binary to main:
This commit moves the
address_mapfield ofFunctionInfointo a
custom-encoded section of the executable. The goal of this commit is, as
previous commits, to push less data throughbincode. Theaddress_map
field is actually extremely large and has huge benefits of not being
decoded when we load a module. This data is only used for traps and such
as well, so it's not overly important that it's massaged in to precise
data the runtime can extremely speedily use.The
FunctionInfotype does retain a tiny bit of information about the
function itself (it's start source location), but other than that the
FunctionAddressMapstructure is moved fromwasmtime-environto
wasmtime-craneliftsince it's now no longer needed outside of that
context.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 25 2021 at 15:02):alexcrichton edited PR #3240 from address-map-binary to main:
This commit moves the
address_mapfield ofFunctionInfointo a
custom-encoded section of the executable. The goal of this commit is, as
previous commits, to push less data throughbincode. Theaddress_map
field is actually extremely large and has huge benefits of not being
decoded when we load a module. This data is only used for traps and such
as well, so it's not overly important that it's massaged in to precise
data the runtime can extremely speedily use.The
FunctionInfotype does retain a tiny bit of information about the
function itself (it's start source location), but other than that the
FunctionAddressMapstructure is moved fromwasmtime-environto
wasmtime-craneliftsince it's now no longer needed outside of that
context.cc #3230
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 25 2021 at 15:25):alexcrichton updated PR #3240 from address-map-binary to main.
Wasmtime GitHub notifications bot (Aug 26 2021 at 14:17):alexcrichton requested peterhuene for a review on PR #3240.
Wasmtime GitHub notifications bot (Aug 26 2021 at 21:55):alexcrichton updated PR #3240 from address-map-binary to main.
Wasmtime GitHub notifications bot (Aug 27 2021 at 01:34):peterhuene submitted PR review.
Wasmtime GitHub notifications bot (Aug 27 2021 at 01:34):peterhuene submitted PR review.
Wasmtime GitHub notifications bot (Aug 27 2021 at 01:34):peterhuene created PR review comment:
/// pc transformed to a relative offset within the text section.
Wasmtime GitHub notifications bot (Aug 27 2021 at 02:19):alexcrichton updated PR #3240 from address-map-binary to main.
Wasmtime GitHub notifications bot (Aug 27 2021 at 04:06):alexcrichton merged PR #3240.
Last updated: Dec 23 2024 at 12:05 UTC