Stream: git-wasmtime

Topic: wasmtime / PR #3234 Implement `IsubBin`, `IsubBout`, and ...

Wasmtime GitHub notifications bot (Aug 24 2021 at 11:25):

dheaton-arm opened PR #3234 from implement-isubb to main:

Implemented the following Opcodes for the Cranelift interpreter:

• IsubBin to subtract two scalar integers with an input borrow flag.
• IsubBout to subtract two scalar integers with an output borrow flag.
• IsubBorrow to subtract two scalar integers with an input and output borrow flag.

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 24 2021 at 11:29):

dheaton-arm edited PR #3234 from implement-isubb to main.

Wasmtime GitHub notifications bot (Aug 25 2021 at 11:55):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Aug 25 2021 at 11:55):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Aug 25 2021 at 11:55):

afonso360 created PR review comment:

Would it be possible to add i64 test cases as well?

Wasmtime GitHub notifications bot (Aug 25 2021 at 11:55):

afonso360 created PR review comment:

Lets wait until this comment is resolved, to see if we do something similar here.

Wasmtime GitHub notifications bot (Sep 01 2021 at 14:31):

dheaton-arm updated PR #3234 from implement-isubb to main.

Wasmtime GitHub notifications bot (Sep 01 2021 at 14:33):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2021 at 18:25):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 01 2021 at 18:25):

cfallin merged PR #3234.

Last updated: Nov 22 2024 at 16:03 UTC