Wasmtime GitHub notifications bot (Aug 20 2021 at 14:11): Wasmtime GitHub notifications bot (Aug 20 2021 at 14:11):bnjbvr opened PR #3219 from fix-vtune to main:
This fixes the VTune build, which was broken on main (and on the latest stable release too, at least).
I've copied the previous strategy to generate global module identifiers (atomic uint incremented as we compile new modules).
Second commit adds the vtune build to CI, so it's not broken again in the future.
Other than that, the vtune profiling page is still up to date, and vtune integration still works on Linux; great stuff!
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:11):bnjbvr updated PR #3219 from fix-vtune to main.
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:37):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:37):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:37):alexcrichton created PR review comment:
I think this is allocating a new module id for each function, which I don't think is what happened before? (I'm not familiar with VTune so I'm not entirely certain)
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:44):bnjbvr updated PR #3219 from fix-vtune to main.
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:44):bnjbvr submitted PR review.
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:44):bnjbvr created PR review comment:
oh my, how embarrassing. Thanks :)
Wasmtime GitHub notifications bot (Aug 20 2021 at 14:44):bnjbvr requested alexcrichton for a review on PR #3219.
Wasmtime GitHub notifications bot (Aug 20 2021 at 15:01):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 20 2021 at 15:17):alexcrichton merged PR #3219.
Last updated: Nov 22 2024 at 16:03 UTC