Stream: git-wasmtime

Topic: wasmtime / PR #3199 Remove `wasmtime-environ`'s dependenc...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 17 2021 at 22:57):

alexcrichton opened PR #3199 from sever-cranelift to main:

This is the next-to-last step to making Wasmtime have a compile-time feature to enable Cranelift as a JIT backend. This commit performs lots of internal refactorings around imports and such and achieves one of the main goals of extracting the types out of cranelift-wasm required by Wasmtime at runtime. These types now live in a new crate at cranelift/wasm-types called cranelift-wasm-types (suggestions for better names most welcome). This crate will not have a dependency on cranelift-codegen (the "meat" of Cranelift) and will be used at both compile time and runtime for Wasmtime.

The end-result of this PR is that cranelift-codegen is depended on by only one crate in Wasmtime's crate graph, which is wasmtime-cranelift itself (as expected). A final future PR will perform the final refactoring to actually compile-out wasmtime-cranelift so it's possible to compile the wasmtime crate without JIT compiler support.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 00:59):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 01:03):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 05:04):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 05:11):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 14:02):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 14:37):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 14:52):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 15:05):

bjorn3 created PR review comment:

Can you move this down to the wasmtime section?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 15:05):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 17:02):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 17:19):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 17:19):

alexcrichton created PR review comment:

I cannot, this list is topologically sorted.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 17:20):

alexcrichton updated PR #3199 from sever-cranelift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 18:14):

alexcrichton merged PR #3199.

Last updated: Dec 23 2024 at 12:05 UTC