Stream: git-wasmtime

Topic: wasmtime / PR #3192 Don't require `DW_AT_comp_dir` for de...

Wasmtime GitHub notifications bot (Aug 16 2021 at 17:49):

alexcrichton opened PR #3192 from no-comp-dir to main:

I'm not too well-versed in this area of debuginfo, but I think this
should address #3184 where it appears not all compilers emit
DW_AT_comp_dir. This seems to match the default behavior of gimli
when it maps an existing line program to a new line program as well
(choosing an empty name for the compilation directory).

Closes #3184

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 17 2021 at 21:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2021 at 21:43):

fitzgen merged PR #3192.

Last updated: Dec 23 2024 at 12:05 UTC