Stream: git-wasmtime

Topic: wasmtime / PR #3178 Remove dependency on TargetIsa from W...

Wasmtime GitHub notifications bot (Aug 11 2021 at 00:35):

alexcrichton opened PR #3178 from less-target-isa to main:

This commit started off by deleting the cranelift_codegen::settings
reexport in the wasmtime-environ crate and then basically played
whack-a-mole until everything compiled again. The main result of this is
that the wasmtime-* family of crates have generally less of a
dependency on the TargetIsa trait and type from Cranelift. While the
dependency isn't entirely severed yet this is at least a significant
start.

This commit is intended to be largely refactorings, no functional
changes are intended here. The refactorings are:

• A CompilerBuilder trait has been added to wasmtime_environ which
  server as an abstraction used to create compilers and configure them
  in a uniform fashion. The wasmtime::Config type now uses this
  instead of cranelift-specific settings. The wasmtime-jit crate
  exports the ability to create a compiler builder from a
  CompilationStrategy, which only works for Cranelift right now. In a
  cranelift-less build of Wasmtime this is expected to return a trait
  object that fails all requests to compile.

• The Compiler trait in the wasmtime_environ crate has been souped
  up with a number of methods that Wasmtime and other crates needed.

• The wasmtime-debug crate is now moved entirely behind the
  wasmtime-cranelift crate.

• The wasmtime-cranelift crate is now only depended on by the
  wasmtime-jit crate.

• Wasm types in cranelift-wasm no longer contain their IR type,
  instead they only contain the WasmType. This is required to get
  everything to align correctly but will also be required in a future
  refactoring where the types used by cranelift-wasm will be extracted
  to a separate crate.

• I moved around a fair bit of code in wasmtime-cranelift.

• Some gdb-specific jit-specific code has moved from wasmtime-debug to
  wasmtime-jit.

Note that this is built on https://github.com/bytecodealliance/wasmtime/pull/3176, but I wanted to keep all these refactorings ideally bite-ish sized to be more easily digestable

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:53):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:53):

bjorn3 created PR review comment:

Just a reminder to either remove or uncomment this code.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:55):

bjorn3 created PR review comment:

Same

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:55):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:56):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:56):

bjorn3 created PR review comment:

    /// Construct a new `Compiler`.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:58):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2021 at 10:58):

bjorn3 created PR review comment:

Same

Wasmtime GitHub notifications bot (Aug 11 2021 at 22:04):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 14:55):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 14:59):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 15:00):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 22:08):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 22:08):

alexcrichton edited PR #3178 from less-target-isa to main:

This commit started off by deleting the cranelift_codegen::settings
reexport in the wasmtime-environ crate and then basically played
whack-a-mole until everything compiled again. The main result of this is
that the wasmtime-* family of crates have generally less of a
dependency on the TargetIsa trait and type from Cranelift. While the
dependency isn't entirely severed yet this is at least a significant
start.

This commit is intended to be largely refactorings, no functional
changes are intended here. The refactorings are:

• A CompilerBuilder trait has been added to wasmtime_environ which
  server as an abstraction used to create compilers and configure them
  in a uniform fashion. The wasmtime::Config type now uses this
  instead of cranelift-specific settings. The wasmtime-jit crate
  exports the ability to create a compiler builder from a
  CompilationStrategy, which only works for Cranelift right now. In a
  cranelift-less build of Wasmtime this is expected to return a trait
  object that fails all requests to compile.

• The Compiler trait in the wasmtime_environ crate has been souped
  up with a number of methods that Wasmtime and other crates needed.

• The wasmtime-debug crate is now moved entirely behind the
  wasmtime-cranelift crate.

• The wasmtime-cranelift crate is now only depended on by the
  wasmtime-jit crate.

• Wasm types in cranelift-wasm no longer contain their IR type,
  instead they only contain the WasmType. This is required to get
  everything to align correctly but will also be required in a future
  refactoring where the types used by cranelift-wasm will be extracted
  to a separate crate.

• I moved around a fair bit of code in wasmtime-cranelift.

• Some gdb-specific jit-specific code has moved from wasmtime-debug to
  wasmtime-jit.

Note that this is built on https://github.com/bytecodealliance/wasmtime/pull/3176, but I wanted to keep all these refactorings ideally bite-ish sized to be more easily digestable

Wasmtime GitHub notifications bot (Aug 12 2021 at 22:18):

alexcrichton updated PR #3178 from less-target-isa to main.

Wasmtime GitHub notifications bot (Aug 12 2021 at 22:19):

alexcrichton requested pchickey for a review on PR #3178.

Wasmtime GitHub notifications bot (Aug 12 2021 at 23:40):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2021 at 23:40):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2021 at 23:40):

pchickey created PR review comment:

I am grateful that we have gotten rid of all these redundant duplications!

Wasmtime GitHub notifications bot (Aug 16 2021 at 14:55):

alexcrichton merged PR #3178.

Last updated: Dec 23 2024 at 12:05 UTC