Wasmtime GitHub notifications bot (Aug 09 2021 at 16:25): Wasmtime GitHub notifications bot (Aug 09 2021 at 16:25):fitzgen opened PR #3171 from fitzgen-patch-1 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:25):fitzgen requested cfallin for a review on PR #3171.
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:29):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:29):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:29):cfallin created PR review comment:
The other example was instruction sinking / load-op merging (which has really subtle conditions!).
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:29):cfallin created PR review comment:
s/Amaneiu/Amanieu/ I think
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:35):fitzgen updated PR #3171 from fitzgen-patch-1 to main.
Wasmtime GitHub notifications bot (Aug 09 2021 at 16:35):fitzgen merged PR #3171.
Last updated: Nov 22 2024 at 17:03 UTC