Stream: git-wasmtime

Topic: wasmtime / PR #3169 wasmtime: Option to disable parallel ...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 14:50):

pepyakin edited PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 15:39):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 15:39):

pepyakin requested peterhuene for a review on PR #3169.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:04):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:04):

alexcrichton created PR review comment:

This is currently intentional in that it takes fn instead of a closure because this is doing caching internally and trying to guarantee that the closure doesn't close over anything that isn't hashed and computed for caching. Is it possible to use the function-based version of this?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:04):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:04):

alexcrichton created PR review comment:

Could this argument be baked into the Compiler itself rather than passed as a parameter? I also think it's fine for it to be an unconditional parameter to avoid the #[cfg] on usage

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:04):

alexcrichton created PR review comment:

I think this macro be be out-living its usefulness as at this point it's branching into somewhat more obscure syntax.

I think our parallel operations are basically all map/collect so perhaps a new method could be exposed on Compiler which does that operation "take this list and run this closure and return the results" where the one method has internal #[cfg] and such for rayon vs not?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:05):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 16:37):

alexcrichton closed without merge PR #3169.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2021 at 17:07):

pepyakin reopened PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 13:55):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:05):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:05):

abrown updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:23):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:23):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:23):

alexcrichton created PR review comment:

I think this no longer needs the #[cfg]?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:38):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 17:42):

pepyakin updated PR #3169 from pep-disable-parallel-compilation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 19:09):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2021 at 19:09):

alexcrichton merged PR #3169.

Last updated: Dec 23 2024 at 12:05 UTC