Stream: git-wasmtime

Topic: wasmtime / PR #3158 Refactor cranelift immediates slightly

Wasmtime GitHub notifications bot (Aug 06 2021 at 15:19):

alexcrichton opened PR #3158 from refactor-immediates-a-bit to main:

I've run up against the Into-vs-From impls a few times and figured
I'd go ahead and put up a refactoring. This switches Into impls into
From impls which allows using both traits instead of just the Into
version. Additionally this removes a few small as casts in favor of
infallible from/into or try_from with error handling.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 06 2021 at 15:29):

alexcrichton closed without merge PR #3158.

Wasmtime GitHub notifications bot (Aug 06 2021 at 15:29):

alexcrichton reopened PR #3158 from refactor-immediates-a-bit to main.

Wasmtime GitHub notifications bot (Aug 06 2021 at 16:13):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Aug 06 2021 at 16:14):

abrown merged PR #3158.

Last updated: Oct 23 2024 at 20:03 UTC