Wasmtime GitHub notifications bot (Aug 05 2021 at 18:14): Wasmtime GitHub notifications bot (Aug 05 2021 at 18:14):alexcrichton opened PR #3149 from better-fuzz-limits to main:
This commit implements a custom resource limiter for fuzzing. Locally I
was seeing a lot of ooms while fuzzing and I believe it was generally
caused from not actually having any runtime limits for wasm modules. I'm
actually surprised that this hasn't come up more on oss-fuzz more in
reality, but with a custom store limiter I think this'll get the job
done where we have an easier knob to turn for controlling the memory
usage of fuzz-generated modules.For now I figure a 2gb limit should be good enough for limiting fuzzer
execution. Additionally the "out of resources" check if instantiation
fails now looks for theoomflag to be set instead of pattern matching
on some error messages about resources.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 05 2021 at 18:27):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 05 2021 at 18:27):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 05 2021 at 19:00):alexcrichton updated PR #3149 from better-fuzz-limits to main.
Wasmtime GitHub notifications bot (Aug 05 2021 at 20:07):alexcrichton merged PR #3149.
Last updated: Dec 23 2024 at 12:05 UTC