Stream: git-wasmtime

Topic: wasmtime / PR #3146 cranelift: Implement nan canonicaliza...

Wasmtime GitHub notifications bot (Aug 05 2021 at 15:33):

alexcrichton opened PR #3146 from canonicalize-simd-nan to main:

This fixes some fuzz bugs that came about enabling simd where nan
canonicalization is performed on the fuzzers but cranelift would panic
on these ops for vectors. This adds some custom codegen with bitselect
to ensure any nan lanes are canonical-nan lanes in the canonicalized
operations.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 05 2021 at 17:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 05 2021 at 18:44):

alexcrichton merged PR #3146.

Last updated: Dec 23 2024 at 12:05 UTC