Stream: git-wasmtime

Topic: wasmtime / PR #3143 Consolidate address calculations for ...

Wasmtime GitHub notifications bot (Aug 04 2021 at 18:36):

alexcrichton opened PR #3143 from update-sthreads to main:

This commit consolidates all calcuations of guest addresses into one
prepare_addr function. This notably remove the atomics-specifics paths
as well as the prepare_load function (now renamed to prepare_addr
and folded into get_heap_addr).

The goal of this commit is to simplify how addresses are managed in the
code generator for atomics to use all the shared infrastrucutre of other
loads/stores as well. This additionally fixes #3132 via the use of
heap_addr in clif for all operations.

I also added a number of tests for loads/stores with varying alignments.
Originally I was going to allow loads/stores to not be aligned since
that's what the current formal specification says, but the overview of
the threads proposal disagrees with the formal specification, so I
figured I'd leave it as-is but adding tests probably doesn't hurt.

Closes #3132

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 04 2021 at 18:46):

alexcrichton requested cfallin for a review on PR #3143.

Wasmtime GitHub notifications bot (Aug 04 2021 at 18:52):

alexcrichton updated PR #3143 from update-sthreads to main.

Wasmtime GitHub notifications bot (Aug 04 2021 at 19:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 04 2021 at 19:45):

alexcrichton updated PR #3143 from update-sthreads to main.

Wasmtime GitHub notifications bot (Aug 04 2021 at 20:06):

alexcrichton updated PR #3143 from update-sthreads to main.

Wasmtime GitHub notifications bot (Aug 04 2021 at 20:57):

alexcrichton merged PR #3143.

Last updated: Nov 22 2024 at 16:03 UTC