Stream: git-wasmtime

Topic: wasmtime / PR #3141 Fix pooling tests on high-cpu-count s...

Wasmtime GitHub notifications bot (Aug 04 2021 at 15:18):

alexcrichton opened PR #3141 from fix-concurrency to main:

This commit fixes an issue where cargo test was failing pretty
reliably on an 80-thread system where many of the pooling tests would
fail in mmap to reserve address space for the linear memories
allocated for a pooling allocator. Each test wants to reserve about 6TB
of address space, and if we let 80 tests do that apparently Linux
doesn't like that and starts returning errors from mmap.

The implementation here is a relatively simple semaphore-lookalike
which allows a fixed amount of concurrency in pooling tests.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 04 2021 at 16:49):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 04 2021 at 16:55):

alexcrichton merged PR #3141.

Last updated: Dec 23 2024 at 12:05 UTC