Stream: git-wasmtime

Topic: wasmtime / PR #3125 Fix unused borrow warning

Wasmtime GitHub notifications bot (Jul 28 2021 at 22:08):

abrown opened PR #3125 from fix-warning to main:

#[warn(unused_must_use)] is on, prompting a compiler warning like:
"unused borrow that must be used".

warning: unused borrow that must be used
   --> crates/debug/src/transform/expression.rs:438:29
    |
438 | / ...                   &code_buf[new_from - 2..new_from]
439 | | ...                       .copy_from_slice(&(new_diff as i16).to_le_bytes());
    | |____________________________________________________________________________^
    |
    = note: `#[warn(unused_must_use)]` on by default

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 28 2021 at 22:12):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 28 2021 at 22:39):

abrown merged PR #3125.

Last updated: Nov 22 2024 at 17:03 UTC