Stream: git-wasmtime

Topic: wasmtime / PR #3122 Add a `wasmtime_linker_define_func` C...

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:00):

alexcrichton opened PR #3122 from c-api-linker-func to main:

This exposes the functionality of the Linker type where a
store-independent function can be created and inserted, allowing a
linker's functions to be used across many stores (instead of requiring
one linker-per-store).

Closes #3110

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:04):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:04):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:04):

pchickey created PR review comment:

I might have named this callback_to_fn, that was the only part of reading this that tripped me up.

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:05):

alexcrichton updated PR #3122 from c-api-linker-func to main.

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 27 2021 at 21:05):

alexcrichton created PR review comment:

Good point, let's go with c_callback_to_rust_fn!

Wasmtime GitHub notifications bot (Jul 27 2021 at 23:56):

alexcrichton merged PR #3122.

Last updated: Nov 22 2024 at 16:03 UTC