Stream: git-wasmtime

Topic: wasmtime / PR #3102 cranelift: Fix trampoline args for b1...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2021 at 11:17):

afonso360 opened PR #3102 from fix-bool-trampolines to main:

Hey,

We're now having issues with this on the fuzzer, since we introduced b1 types in #3094.

The assert was complaining because we identify DataValue::B's as B8's. I think we are ok disabling this assert for bools, because we are always going to have a size mismatch, and this check is not meaningful for this type.

Fixing trampoline bool args is tracked in #2237

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2021 at 13:18):

afonso360 updated PR #3102 from fix-bool-trampolines to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 08 2021 at 16:43):

afonso360 updated PR #3102 from fix-bool-trampolines to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2021 at 22:50):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2021 at 22:50):

cfallin merged PR #3102.

Last updated: Dec 23 2024 at 13:07 UTC