Stream: git-wasmtime

Topic: wasmtime / PR #3096 Riscv disassembler support

Wasmtime GitHub notifications bot (Jul 19 2021 at 09:38):

crab2313 opened PR #3096 from riscv-disassemble to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

capstone v0.9 released recently support RISC-V already.

Wasmtime GitHub notifications bot (Jul 19 2021 at 09:56):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2021 at 09:56):

bjorn3 created PR review comment:

I think these should use .set_skipdata like AArch64. That ensures that capstone prints inline constant pools as raw bytes instead of truncating the instruction stream.

Wasmtime GitHub notifications bot (Jul 19 2021 at 10:20):

crab2313 updated PR #3096 from riscv-disassemble to main.

Wasmtime GitHub notifications bot (Jul 19 2021 at 10:21):

crab2313 submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2021 at 10:21):

crab2313 created PR review comment:

I will fix that.

Wasmtime GitHub notifications bot (Jul 19 2021 at 16:27):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2021 at 16:27):

pchickey merged PR #3096.

Last updated: Nov 22 2024 at 16:03 UTC