Wasmtime GitHub notifications bot (Jul 14 2021 at 20:26): Wasmtime GitHub notifications bot (Jul 14 2021 at 20:26):alexcrichton opened PR #3088 from stack-limits to main:
Previously the stack pointer limit wasn't adjusted, even in the face of
stack switching. This commit updates the logic around the stack limit
calculation to configure it on all async function calls, even if they're
recursive. Synchronous function calls, however, continue to only
configure the stack limit at the start, not for recursive calls.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 14 2021 at 20:31):alexcrichton updated PR #3088 from stack-limits to main.
Wasmtime GitHub notifications bot (Jul 14 2021 at 20:37):peterhuene submitted PR review.
Wasmtime GitHub notifications bot (Jul 14 2021 at 20:37):peterhuene submitted PR review.
Wasmtime GitHub notifications bot (Jul 14 2021 at 20:37):peterhuene created PR review comment:
/// WebAssembly is entered within the `Store`.
Wasmtime GitHub notifications bot (Jul 14 2021 at 20:50):alexcrichton updated PR #3088 from stack-limits to main.
Wasmtime GitHub notifications bot (Jul 14 2021 at 21:32):alexcrichton merged PR #3088.
Last updated: Oct 23 2024 at 20:03 UTC