Wasmtime GitHub notifications bot (Jul 10 2021 at 11:33): Wasmtime GitHub notifications bot (Jul 10 2021 at 11:33):afonso360 opened PR #3074 from aarch-ishl-i8 to main:
This PR addresses two issues:
- A panic when shifting any non i128 type by i128 amounts (#3064)
- Wrong results when lowering shifts with small types (i8, i16)
In these types when shifting for amounts larger than the size of the
type, we would not get the wrapping behaviour that we see on i32 and i64.
This is because in these larger types, the wrapping behaviour is automatically
implemented by using the appropriate instruction, however we do not
have i8 and i16 specific instructions, so we have to manually wrap
the shift amount with an AND instruction.This issue is also found on x86_64 and s390x, and a separate issue will
be filed for those.Closes #3064
Wasmtime GitHub notifications bot (Jul 10 2021 at 11:36):afonso360 updated PR #3074 from aarch-ishl-i8 to main.
Wasmtime GitHub notifications bot (Jul 10 2021 at 11:44):afonso360 updated PR #3074 from aarch-ishl-i8 to main.
Wasmtime GitHub notifications bot (Jul 10 2021 at 12:36):afonso360 updated PR #3074 from aarch-ishl-i8 to main.
Wasmtime GitHub notifications bot (Jul 14 2021 at 13:47):akirilov-arm submitted PR review.
Wasmtime GitHub notifications bot (Jul 14 2021 at 13:47):akirilov-arm submitted PR review.
Wasmtime GitHub notifications bot (Jul 14 2021 at 13:47):akirilov-arm created PR review comment:
Another potential optimization here is to use the shift destination register instead of a temporary one.
Wasmtime GitHub notifications bot (Jul 14 2021 at 13:47):akirilov-arm created PR review comment:
Could you extract this helper function to
lower.rs?
Wasmtime GitHub notifications bot (Jul 15 2021 at 21:14):afonso360 updated PR #3074 from aarch-ishl-i8 to main.
Wasmtime GitHub notifications bot (Jul 15 2021 at 22:29):afonso360 requested akirilov-arm for a review on PR #3074.
Wasmtime GitHub notifications bot (Jul 15 2021 at 23:15):akirilov-arm submitted PR review.
Wasmtime GitHub notifications bot (Jul 16 2021 at 21:08):akirilov-arm merged PR #3074.
Last updated: Nov 22 2024 at 16:03 UTC