Stream: git-wasmtime

Topic: wasmtime / PR #3057 Implement Display for settings::Value

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 12:36):

bjorn3 opened PR #3057 from display_setting_value to main:

cc #1069

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 18:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 18:28):

cfallin created PR review comment:

Can we write this if-chain as a match on self.detail?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 18:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 18:34):

bjorn3 created PR review comment:

self.details doesn't directly contain the value. It only contains information how to get the value. The logic is non-trivial for some types, so I wanted to avoid duplication.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 18:34):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 19:02):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 19:02):

cfallin created PR review comment:

Fair enough, this is reasonable too.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2021 at 19:03):

cfallin merged PR #3057.

Last updated: Oct 23 2024 at 20:03 UTC