bjorn3 opened PR #3057 from display_setting_value
to main
:
cc #1069
cfallin submitted PR review.
cfallin created PR review comment:
Can we write this if-chain as a
match
onself.detail
?
cfallin submitted PR review.
bjorn3 created PR review comment:
self.details
doesn't directly contain the value. It only contains information how to get the value. The logic is non-trivial for some types, so I wanted to avoid duplication.
bjorn3 submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
Fair enough, this is reasonable too.
cfallin merged PR #3057.
Last updated: Dec 23 2024 at 12:05 UTC