Wasmtime GitHub notifications bot (Jun 24 2021 at 18:31): Wasmtime GitHub notifications bot (Jun 24 2021 at 18:31):alexcrichton opened PR #3029 from fix-4gb-fuzz to main:
Wasmtime was updated to reject creation of memories exactly 4gb in size
in #3013, but the fuzzers still had the assumption that any request to
create a host object for a particular wasm type would succeed.
Unfortunately now, though, a request to create a 4gb memory fails. This
is an expected failure, though, so the fix here was to catch the error
and allow it.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 24 2021 at 18:37):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 24 2021 at 18:37):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 24 2021 at 18:37):cfallin created PR review comment:
Would it make sense to have a slightly more specific match here? E.g. "Insufficient resources: memory" or somesuch?
Wasmtime GitHub notifications bot (Jun 24 2021 at 19:08):alexcrichton updated PR #3029 from fix-4gb-fuzz to main.
Wasmtime GitHub notifications bot (Jun 24 2021 at 19:53):alexcrichton merged PR #3029.
Last updated: Nov 22 2024 at 16:03 UTC