Wasmtime GitHub notifications bot (Jun 23 2021 at 17:34): Wasmtime GitHub notifications bot (Jun 23 2021 at 17:34):alexcrichton opened PR #3023 from refactor-instance to main:
This commit slims down the list of builtin intrinsics. It removes the
duplicated intrinsics for imported and locally defined items, instead
always using one intrinsic for both. This was previously inconsistently
applied where some intrinsics got two copies (one for imported one for
local) and other intrinsics got only one copy. This does add an extra
branch in intrinsics since they need to determine whether something is
local or not, but that's generally much lower cost than the intrinsics
themselves.This also removes the
memory32_sizeintrinsic, instead inlining the
codegen directly into the clif IR. This matches what thetable.size
instruction does and removes the need for a few functions on a
wasmtime_runtime::Instance.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 23 2021 at 18:21):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 23 2021 at 18:21):fitzgen merged PR #3023.
Last updated: Dec 23 2024 at 13:07 UTC