Stream: git-wasmtime

Topic: wasmtime / PR #3021 Refactor some internal accessors of I...

Wasmtime GitHub notifications bot (Jun 22 2021 at 20:07):

alexcrichton opened PR #3021 from refactor-instance to main:

This commit removes some one-use methods to inline them at their use
site, and otherwise adds bounds checks to other functions like
imported_function where previously the FuncIndex may have been
accidentally out of bounds, which would cause memory unsafety. There's
no actual bug this was fixing, just trying to improve the safety of the
code internally a little.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 23 2021 at 17:04):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 23 2021 at 17:12):

alexcrichton merged PR #3021.

Last updated: Dec 23 2024 at 12:05 UTC