Stream: git-wasmtime

Topic: wasmtime / PR #3012 s390x: Basic support for IaddIfcout

Wasmtime GitHub notifications bot (Jun 22 2021 at 12:00):

uweigand opened PR #3012 from s390x-addcarry to main:

This adds enough support for the IaddIfcout opcode to make the
code emitted by dynamic_addr work on s390x.

Note: On s390x, the condition code mask that has to be used to
implement unsigned_add_overflow_condition does not match any of
the masks for the "normal" condition codes, so this design is
not really a good match for s390x ...

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 22 2021 at 18:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 22 2021 at 18:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 22 2021 at 18:13):

cfallin created PR review comment:

Could we add a comment here noting what these constants are (which condition flags) and how the combination of the add instruction generated by IaddIfcout and the condcode here will properly trap?

Perhaps also a note in unsigned_add_overflow_condition() would be helpful in order to describe how the condition code is actually specially handled in the one place this is known to be used.

Wasmtime GitHub notifications bot (Jun 22 2021 at 18:36):

uweigand updated PR #3012 from s390x-addcarry to main.

Wasmtime GitHub notifications bot (Jun 22 2021 at 19:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 22 2021 at 19:19):

cfallin merged PR #3012.

Last updated: Nov 22 2024 at 16:03 UTC