Wasmtime GitHub notifications bot (Jun 21 2021 at 14:27): Wasmtime GitHub notifications bot (Jun 21 2021 at 14:27):alexcrichton opened PR #3010 from fix-dylib to main:
This commit adds a
#[link]annotation to the block defining symbols
coming from a native static library that we build and link. This is
required by rustc to get symbols to get exported correctly when linking
wasmtime into a Rust dynamic library instead of always as an rlib.While I was at it I went ahead and renamed the symbols now that they're
no longer in C++ and they're doing setjmp/longjmp and not much else.Closes #3006
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 21 2021 at 15:54):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 21 2021 at 15:54):cfallin merged PR #3010.
Last updated: Nov 22 2024 at 16:03 UTC