Stream: git-wasmtime

Topic: wasmtime / PR #3009 [RFC] Remove the old x86 backend

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 11:22):

bjorn3 opened PR #3009 from bye_x86_backend to main:

The default has been switched to the new x64 backend a while ago. AFAIK nobody has had any problems with the new x64 backend that required switching back to the old x86 backend.

This PR removes the old x86 backend, and the cranelift-codegen-meta part of the encoding and legalization mechanism of the old backend. The cranelift-codegen parts are only removed where necessary to fix warnings.

Based on #3007

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 11:24):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 14:29):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 15:37):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 16:24):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 16:43):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 17:45):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 18:13):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 18:13):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 18:13):

cfallin created PR review comment:

Can you rename this to just lookup (and remove the wrapper below)? This was added to accept the extra variant arg and so I don't think we need it any more.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 18:59):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 19:02):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 19:03):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 19:03):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:08):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:12):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:12):

cfallin created PR review comment:

It looks like the latest force-push lost this update?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:37):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:38):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2021 at 20:38):

bjorn3 created PR review comment:

Right, forgot to commit it again before force pushing.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2021 at 10:42):

bjorn3 updated PR #3009 from bye_x86_backend to main.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2021 at 16:20):

cfallin merged PR #3009.

Last updated: Dec 23 2024 at 12:05 UTC