Stream: git-wasmtime

Topic: wasmtime / PR #3005 aarch64: Implement uextend/sextend fo...

Wasmtime GitHub notifications bot (Jun 20 2021 at 14:44):

afonso360 opened PR #3005 from aarch64-i128-extend to main:

Hey, a few more ops for i128 support

Wasmtime GitHub notifications bot (Jun 20 2021 at 14:50):

afonso360 updated PR #3005 from aarch64-i128-extend to main.

Wasmtime GitHub notifications bot (Jun 21 2021 at 08:39):

afonso360 updated PR #3005 from aarch64-i128-extend to main.

Wasmtime GitHub notifications bot (Jun 21 2021 at 16:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 21 2021 at 16:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 21 2021 at 16:52):

cfallin created PR review comment:

Can we clarify the logic a bit by adding a let pass_through_lower = to_bits > 64 && !needs_lower_extend here, then moving the move-emission below (will comment separately)?

Wasmtime GitHub notifications bot (Jun 21 2021 at 16:52):

cfallin created PR review comment:

With the above pass_through_lower, could we do an else if pass_through_lower { ctx.emit(/* move */) } here? I like that arrangement a bit better as it gives a clear separation between "produce lower register" and "produce upper register" parts of the code.

Wasmtime GitHub notifications bot (Jun 22 2021 at 11:24):

afonso360 updated PR #3005 from aarch64-i128-extend to main.

Wasmtime GitHub notifications bot (Jun 22 2021 at 11:53):

afonso360 requested cfallin for a review on PR #3005.

Wasmtime GitHub notifications bot (Jun 22 2021 at 17:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 22 2021 at 17:24):

cfallin merged PR #3005.

Last updated: Nov 22 2024 at 17:03 UTC