Stream: git-wasmtime

Topic: wasmtime / PR #3002 aarch64 implement brz,brnz,br_icmp fo...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2021 at 21:06):

afonso360 opened PR #3002 from aarch64-i128-br to main:

Hey,

This PR implements a few branches for i128 values.

It also cleans up a bit of duplicated logic for lowering icmp

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 16:44):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 16:44):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 16:44):

cfallin created PR review comment:

I wonder: would it be better here to do an ORRS into XZR and then branch on the Z flag (here and for brnz below)? That would avoid the need to clobber a register, reducing pressure.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 17:07):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 17:07):

afonso360 created PR review comment:

I think ORRS is no longer an instruction in aarch64, at least I'm not finding it in the instruction listing

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 17:52):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 17:52):

cfallin created PR review comment:

Ah! I have been deceived by old ARM32 online docs, then; in this case, I agree this is probably the best we can do. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2021 at 17:52):

cfallin merged PR #3002.

Last updated: Dec 23 2024 at 12:05 UTC