Stream: git-wasmtime

Topic: wasmtime / PR #3001 Fix running enter/exit hooks on start...

Wasmtime GitHub notifications bot (Jun 18 2021 at 20:32):

alexcrichton opened PR #3001 from better-enter-exit to main:

This commit fixes running the store's enter/exit hooks into wasm which
accidentally weren't run for an instance's start function. The fix
here was mostly to just sink the enter/exit hook much lower in the code
to invoke_wasm_and_catch_traps, which is the common entry point for
all wasm calls.

This did involve propagating the StoreContext<T> generic rather than
using StoreOpaque unfortunately, but it is overally not too too much
code and we generally wanted most of it inlined anyway.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 21 2021 at 20:56):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 21 2021 at 21:31):

alexcrichton merged PR #3001.

Last updated: Dec 23 2024 at 12:05 UTC