alexcrichton opened PR #2993 from clone-linker
to main
:
There's no real reason to not do this, and it can help with some
usability use cases!<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
peterhuene submitted PR review.
sunfishcode created PR review comment:
It looks like all the fields are cloned; could this use
#[derive(Clone)]
instead?
sunfishcode submitted PR review.
pchickey submitted PR review.
pchickey created PR review comment:
Deriving clone would constrain it to
T: Clone
which is not what we want
sunfishcode submitted PR review.
sunfishcode created PR review comment:
Ah, ok.
alexcrichton merged PR #2993.
Last updated: Dec 23 2024 at 12:05 UTC