Stream: git-wasmtime

Topic: wasmtime / PR #2991 s390x: Add z14 support


view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 13:06):

uweigand opened PR #2991 from s390x-z14 to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 17:18):

uweigand updated PR #2991 from s390x-z14 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 17:47):

uweigand updated PR #2991 from s390x-z14 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin created PR review comment:

It's too bad this isn't in the stdlib yet -- are there plans to try to upstream this? It looks like the [std_detect crate] in the stdlib has similar implementations that use the ELF auxvec capability word(s) on other architectures.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin created PR review comment:

Just a little style nit, but these should be doc-comments (///), I think.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:49):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2021 at 19:49):

bjorn3 created PR review comment:

Apart from is_x86_feature_detected! I believe the target detection macros are all unstable anyway.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand updated PR #2991 from s390x-z14 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand created PR review comment:

Fixed.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:20):

uweigand created PR review comment:

Agreed, in the long run we'll want to have this in stdlib like the other platforms.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:20):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 08:23):

uweigand updated PR #2991 from s390x-z14 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 15:24):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2021 at 15:24):

cfallin merged PR #2991.


Last updated: Dec 23 2024 at 13:07 UTC