Stream: git-wasmtime

Topic: wasmtime / PR #2991 s390x: Add z14 support

Wasmtime GitHub notifications bot (Jun 16 2021 at 13:06):

uweigand opened PR #2991 from s390x-z14 to main:

• Add support for processor features (including auto-detection).

• Move base architecture set requirement back to z14.

• Add z15 feature sets and re-enable z15-specific code generation
  when required features are available.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 16 2021 at 17:18):

uweigand updated PR #2991 from s390x-z14 to main.

Wasmtime GitHub notifications bot (Jun 16 2021 at 17:47):

uweigand updated PR #2991 from s390x-z14 to main.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin created PR review comment:

It's too bad this isn't in the stdlib yet -- are there plans to try to upstream this? It looks like the [std_detect crate] in the stdlib has similar implementations that use the ELF auxvec capability word(s) on other architectures.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin created PR review comment:

Just a little style nit, but these should be doc-comments (///), I think.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:01):

cfallin edited PR review comment.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:49):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2021 at 19:49):

bjorn3 created PR review comment:

Apart from is_x86_feature_detected! I believe the target detection macros are all unstable anyway.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand updated PR #2991 from s390x-z14 to main.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:17):

uweigand created PR review comment:

Fixed.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:20):

uweigand created PR review comment:

Agreed, in the long run we'll want to have this in stdlib like the other platforms.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:20):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Jun 17 2021 at 08:23):

uweigand updated PR #2991 from s390x-z14 to main.

Wasmtime GitHub notifications bot (Jun 17 2021 at 15:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 17 2021 at 15:24):

cfallin merged PR #2991.

Last updated: Nov 22 2024 at 16:03 UTC