Stream: git-wasmtime

Topic: wasmtime / PR #2962 Add the ability to cache typechecking...

Wasmtime GitHub notifications bot (Jun 03 2021 at 14:30):

alexcrichton opened PR #2962 from pre-instantiate to main:

This commit adds the abilty to cache the type-checked imports of an
instance if an instance is going to be instantiated multiple times. This
can also be useful to do a "dry run" of instantiation where no wasm code
is run but it's double-checked that a Linker possesses everything
necessary to instantiate the provided module.

This should ideally help cut down repeated instantiation costs slightly
by avoiding type-checking and allocation a Vec<Extern> on each
instantiation. It's expected though that the impact on instantiation
time is quite small and likely not super significant. The functionality,
though, of pre-checking can be useful for some embeddings.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 03 2021 at 14:51):

alexcrichton updated PR #2962 from pre-instantiate to main.

Wasmtime GitHub notifications bot (Jun 03 2021 at 21:44):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:04):

alexcrichton merged PR #2962.

Last updated: Dec 23 2024 at 12:05 UTC